<html>
<head><meta charset="utf-8"><title>new release of measureme · t-compiler/wg-self-profile · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/index.html">t-compiler/wg-self-profile</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html">new release of measureme</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="209709020"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/new%20release%20of%20measureme/near/209709020" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> andjo403 <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html#209709020">(Sep 10 2020 at 21:04)</a>:</h4>
<p>When I was looking at updating the dependencies for rustc, I noticed that measureme is the only thing that holds back that only one version of parking_lot i compiled so do you think that it is possible to make a new release of measureme?<br>
it looks like there is no breaking changes for measureme from 0.7.1 until what is on master now but there is one dependency removed and parking_lot is updated</p>



<a name="209709637"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/new%20release%20of%20measureme/near/209709637" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> andjo403 <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html#209709637">(Sep 10 2020 at 21:10)</a>:</h4>
<p><a href="https://github.com/rust-lang/measureme/compare/0.7.1...master">https://github.com/rust-lang/measureme/compare/0.7.1...master</a><br>
the only thing that I can see for measureme in that diff is the removal of byteorder and adding some  "Send + Sync" to some results</p>



<a name="209752383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/new%20release%20of%20measureme/near/209752383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html#209752383">(Sep 11 2020 at 08:18)</a>:</h4>
<p>I think the <code>Send+Sync</code> changes are breaking changes but those are easy to fix.</p>



<a name="209752721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/new%20release%20of%20measureme/near/209752721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html#209752721">(Sep 11 2020 at 08:22)</a>:</h4>
<p>I wonder if we could drop the <code>parking_lot</code> dependency altogether. On x86_64 Linux the <code>std</code> Mutex implementation performs about the same. But I don't know about other platforms.</p>



<a name="209758667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/new%20release%20of%20measureme/near/209758667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> andjo403 <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html#209758667">(Sep 11 2020 at 09:31)</a>:</h4>
<p>Hmm do not know why I was thinking last night the send sync was backwards compatible.<br>
About the parking_lot dependency I do not know there is already multiple other crates in rustc that use it.<br>
But if you think there is no benefit, less dependencies to keep updated is better.</p>



<a name="209764810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/new%20release%20of%20measureme/near/209764810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html#209764810">(Sep 11 2020 at 10:37)</a>:</h4>
<blockquote>
<p>But if you think there is no benefit</p>
</blockquote>
<p>It's hard to tell without profiling on all the major platforms</p>



<a name="209773413"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/new%20release%20of%20measureme/near/209773413" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html#209773413">(Sep 11 2020 at 12:25)</a>:</h4>
<p>There's a breaking change in progress (maybe two) so I think it's best to wait a bit for the dust to settle and then we can ship a single new version with all the breaking changes.</p>



<a name="211243040"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/new%20release%20of%20measureme/near/211243040" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/new.20release.20of.20measureme.html#211243040">(Sep 25 2020 at 10:54)</a>:</h4>
<p><a href="https://github.com/rust-lang/measureme/pull/132">https://github.com/rust-lang/measureme/pull/132</a> is almost done but before we do a new release, I'd also like to fix an issue where <code>measureme</code> crashes when writing too much data (e.g. when compiling <code>rustc_middle</code>). It should be easy enough to push the boundary from 1GB to 4GB.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>